Skip to content

Update to ACK runtime v0.40.0, code-generator v0.40.0#124

Merged
ack-prow[bot] merged 2 commits intomainfrom
ack-bot/rt-v0.40.0-codegen-v0.40.0
Dec 11, 2024
Merged

Update to ACK runtime v0.40.0, code-generator v0.40.0#124
ack-prow[bot] merged 2 commits intomainfrom
ack-bot/rt-v0.40.0-codegen-v0.40.0

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Dec 9, 2024

Update to ACK runtime v0.40.0, code-generator v0.40.0

NOTE:
This PR increments the release version of service controller from v1.3.13 to v1.3.14

Once this PR is merged, release v1.3.14 will be automatically created for iam-controller

Please close this PR, if you do not want the new patch release for iam-controller

stdout for make build-controller:

building ack-generate ... ok.
==== building iam-controller ====
Copying common custom resource definitions into iam
Building Kubernetes API objects for iam
Generating deepcopy code for iam
Generating custom resource definitions for iam
Building service controller for iam
Generating RBAC manifests for iam
Running gofmt against generated code for iam
Updating additional GitHub repository maintenance files
==== building iam-controller release artifacts ====
Building release artifacts for iam-v1.3.14
Generating common custom resource definitions
Generating custom resource definitions for iam
Generating RBAC manifests for iam

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Dec 9, 2024
@ack-prow ack-prow bot requested review from a-hilaly and jaypipes December 9, 2024 17:28
a-hilaly
a-hilaly approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@ack-prow
Copy link

ack-prow bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Dec 11, 2024
@ack-prow
Copy link

ack-prow bot commented Dec 11, 2024

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
iam-verify-attribution 18845c6 link false /test iam-verify-attribution

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow ack-prow bot merged commit d59b83e into main Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jaypipes jaypipes Awaiting requested review from jaypipes

Assignees

@a-hilaly a-hilaly

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ack-bot @a-hilaly